Add new way to create a volume snapshot from instance quick view tooltip#3406
Merged
Merged
Conversation
DennisKonrad
added
component:UI
type:new-feature
type:enhancement
and removed
type:new-feature
labels
DennisKonrad
approved these changes
Jun 17, 2019
Contributor
svenvogel
approved these changes
Jun 17, 2019
Contributor
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
anuragaw
approved these changes
Jun 18, 2019
Contributor
anuragaw
left a comment
anuragaw
left a comment
There was a problem hiding this comment.
LGTM based on code and local testing on KVM
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2898 |
Contributor
|
ping @rhtyd ready to merge? |
Member
|
Let's do it @svenvogel cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a shortcut to take a volume snapshot of a VM directly from the instance view. Therefor an option was added to the quick view tooltip. On activation a new dialog will pop up, which is based on the original dialog for creating a volume snapshot (Storage > Volumes > Take snapshot) extended with a select menu to choose the desired snapshot volume of the VM.
Types of changes
Screenshots:
New shortcut to take a volume snapshot of a VM
The dialog is based on the original from Storage > Volumes > Take snapshot
How Has This Been Tested?
Deployed to local environment and tested functionality.